search

mopidy / mopidy-local-sqlite

DEPRECATED (Mopidy SQLite local library extension)
https://mopidy.com
Apache License 2.0
30 stars 10 forks source link

Exclude album num_tracks and images when generating md5 URIs #46

Closed tkem closed 4 years ago

tkem commented 9 years ago

Currently, a multi-disc album will generate multiple album rows if the album doesn't have a musicbrainz_id and individual discs have different track counts, due to the way md5 URIs are calculated. According to Mopidy's metadata model, these should be handled as a single album. Note that this will not fix the album's num_tracks, which should probably be set to the total number of tracks, which is difficult to determine if a track's tags only provide the number of tracks for its disc.

Different album tracks may also include different images. Since Mopidy only handles album artwork for now, this will also create multiple album instances, unless the album URI is created from a musicbrainz_id.

tkem commented 9 years ago

See also https://discuss.mopidy.com/t/data-model-semantics-of-num-tracks-for-multi-disc-albums/526

tkem commented 9 years ago

So maybe this is a good reason to introduce path URIs after all, i.e. Using the track URIs path up to the last (file) segment as the album URI. Will still mess up track numbers for most people, and produce unpredictable results for flat file hierarchies, so this should be configurable.

tkem commented 4 years ago

AFAICS, excluging num_tracks has already been implemented in Mopidy-Local, and images are no longer part of the Album model, so...