Merging mopidy-local-sqlite and mopidy-local-images into mopidy-local

mopidy / mopidy-local

Mopidy extension for playing music from your local music archive

https://mopidy.com/ext/local/

Apache License 2.0

62 stars 26 forks source link

Merging mopidy-local-sqlite and mopidy-local-images into mopidy-local #10

Closed tkem closed 4 years ago

tkem commented 5 years ago

My initial attempt, don't judge too harshly ;-) I split up the Local library into LocalLibraryProvider and LocalStorageProvider, the latter being used by mopidy local scan only. Otherwise, this is pretty straight-forward, no attempt at cleaning things up except for getting rid of some config settings that (probably) nobody used, anyway. I did some very basic testing, and it seems to basically work. One thing I noticed was that when scanning a large (~20,000 tracks) library, mopidy local scan uses several GB of memory. That's something we should investigate further.

jodal commented 5 years ago

:heart:

tkem commented 4 years ago

Updated according to https://gist.github.com/jodal/6c011e327035cc4ad56dbc2e3c28f1eb (to my best knowledge) and tested basic functionality with Mopidy 3.0.0a6. Probably still lots of bugs, also disabled some unit tests for now, most noticeably test_translator.py. I'd especially welcome input on translator.py, i.e. using pathlib for handling file paths, etc. Note that the README still needs to be updated with new config parameters, etc.

tkem commented 4 years ago

@jodal, @kingosticks: Thanks for reviewing! I don't know how much time I can spend on this short-term, so since this basically seems to work (at least for me), I'd also suggest just merging this and doing the rest iteratively...