A proper home for `find_mtimes()`

mopidy / mopidy-local

Mopidy extension for playing music from your local music archive

https://mopidy.com/ext/local/

Apache License 2.0

62 stars 26 forks source link

A proper home for `find_mtimes()` #19

Closed jodal closed 4 years ago

jodal commented 4 years ago

[Moved from PR comment in #10.]

In Mopidy, mopidy.internal.path.find_times() is now a reexport of mopidy.internal.mtimes.find_times(). It is only used by tests/audio/test_scan.py. I think that we should either:

conclude that the mopidy.internal.mtimes module belongs in Mopidy-Local and not Mopidy, or
make find_times() a public method, maybe in the mopidy.audio.scan module?

@adamcik Any thoughts on the placement of the scanner and its supporting functions?

adamcik commented 4 years ago

I would err towards moving out. The find time stuff is all done for local's scanner at least, while I think the scanner might be used by e.g. the stream backend? If so we need to keep at least some of it mopidy.