search

mopidy / mopidy-local

Mopidy extension for playing music from your local music archive
https://mopidy.com/ext/local/
Apache License 2.0
61 stars 26 forks source link

Add back use_artist_mbid_uri and use_album_mbid_uri #27

Closed fatg3erman closed 4 years ago

fatg3erman commented 4 years ago

At least on my collection of files, about 10% of them don't sort correctly when using MBIDs to create URIs. I tag all my files using Picard, so I can't be the only person who'll encounter this.

Fixes #26

kingosticks commented 4 years ago

Running tox locally is worth doing before committing/pushing, this includes black ..

fatg3erman commented 4 years ago

Yeah, I'm having difficulty getting the full development virtualenv to work on macOS. I had it working with python 2.7 but even then only for mopidy core, I could never get it to find extensions. Currently it's totally broken and I don't understand why.

kingosticks commented 4 years ago

Ah OK well I can't help at all with that. You could try posting in discourse to see if anyone else has a working mac dev environment. Or @jodal may have some tips.

tkem commented 4 years ago

@fatg3erman: as discussed in #26, getting rid of the mbid URI scheme altogether for now would probably be a better option than re-introducing those configuration options. Could you be bothered to create another PR for that - should be much easier, effectively removing just a few lines? Or shall I close this and give it a try myself?

fatg3erman commented 4 years ago

@tkem yes I can do that, need to find the time to get round to it but as you say it won't be hard.

fatg3erman commented 4 years ago

Closing - will create a new one (on a new branch) to remove these options.