search

mopidy / mopidy-local

Mopidy extension for playing music from your local music archive
https://mopidy.com/ext/local/
Apache License 2.0
61 stars 26 forks source link

Scanner improvements #29

Closed jodal closed 4 years ago

jodal commented 4 years ago

I started out with the goal of removing the mopidy.internal.path usage from the scanner, but I ended up with a bit more.

Review commit by commit is recommended.

codecov[bot] commented 4 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.25%. The diff coverage is 26.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   50.79%   51.04%   +0.25%     
==========================================
  Files           9        9              
  Lines         754      764      +10     
==========================================
+ Hits          383      390       +7     
- Misses        371      374       +3
Impacted Files Coverage Δ
mopidy_local/commands.py 0% <0%> (ø) :arrow_up:
mopidy_local/translator.py 100% <100%> (+16.66%) :arrow_up:
mopidy_local/storage.py 44.56% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 152a0e1...1d7da69. Read the comment docs.

kingosticks commented 4 years ago

Looks good to me

jodal commented 4 years ago

@kingosticks @adamcik Can you have a look at the new commits too?

kingosticks commented 4 years ago

Couple of minor things but LGTM