search

mopidy / mopidy-soundcloud

Mopidy extension for playing music from SoundCloud
https://mopidy.com/ext/soundcloud/
MIT License
183 stars 58 forks source link

Python3 backend is not returning images #111

Open fatg3erman opened 4 years ago

fatg3erman commented 4 years ago

Before Python3, when I searched soundcloud via the MPD interface I would always get an X-AlbumImage field with an image URL that I could display. Since Python3, that field is no longer there.

Images are pretty important for SoundCloud and other backends (eg Youtube) where it's generally not possible to find images online using something like Last.FM or Musicbrainz.

I seem to recall that images were being moved internally to a new API, but I'd like to ask for that decision to be reconsidered, as what was there before worked perfectly.

dreamlayers commented 4 years ago

The old album image code was removed for Mopidy 3 compatibility in https://github.com/mopidy/mopidy-soundcloud/commit/e4efb79f0e526d3d63180d56a195e96c4bc436cf

The new method, via a get_images() method of the library provider, is usable but less convenient. It seems to require either a second request to SoundCloud to get info on the track again, or caching. There is already a cache which caches some function results.

You're probably not going to get Mopidy API decisions reconsidered by suggesting that here.

Edit: Proposed fix at https://github.com/dreamlayers/mopidy-soundcloud/commit/5320324fe5a5d307b950f1f393cc7445338a89a9

weilbith commented 3 years ago

Was there any work on this?

kingosticks commented 3 years ago

If someone wants to take that proposed fix, give it a test and submit a PR, we can merge it.