search

mopidy / mopidy-soundcloud

Mopidy extension for playing music from SoundCloud
https://mopidy.com/ext/soundcloud/
MIT License
185 stars 59 forks source link

Host authenticate page with Mopidy's webserver #32

Closed jodal closed 8 years ago

jodal commented 10 years ago

With the new web extension support, we should be able to move http://www.mopidy.com/authenticate to be a part of the Mopidy-SoundCloud extension, hosted on Mopidy's own web server.

You'd of course need to use window.location as part of the redirect_uri that is passed to SoundCloud, instead of http://www.mopidy.com/soundcloud_callback.

jodal commented 10 years ago

When trying to change redirect_uri I get redirected to the original callback URI with the following added as GET parameters to the URL:

?error=redirect_uri_mismatch&error_description=The+redirection+URI+provided+does+not+match+a+pre-registered+value.

Thus, I guess this may be not possible.

dz0ny commented 10 years ago

Not possible indeed. Another way is to use https://developers.soundcloud.com/docs/api/guide#authentication, but that would mean that user must create his own app, or us exposing client_secret...

jodal commented 8 years ago

Any regular user would much rather authenticate on https://www.mopidy.com/authenticate than registering their own app to do it on http://localhost:6680/something. If the user trusts our code to run on their system, they should be able to trust that the authenticate code on www.mopidy.com doesn't send their SoundCloud token off to some server.

Closing as unfeasible/not interesting.

dz0ny commented 8 years ago

They can also override client_id in settings and generate client_secret via SoundCoud page.