search

mopidy / mopidy-spotify

Mopidy extension for playing music from Spotify
https://mopidy.com/ext/spotify/
Apache License 2.0
933 stars 109 forks source link

Support browsing of albums and tracks from the "Your music" library #238

Closed kingosticks closed 4 years ago

kingosticks commented 4 years ago

Thought I needed to rejig the translator to support simple and full web objects. However, it actually turns out can get away with not doing that since can still load albums using libspotify. So have ripped that back out to simplify this change.

Done tests.

codecov[bot] commented 4 years ago

Codecov Report

Merging #238 into master will increase coverage by 0.16%. The diff coverage is 98.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   96.56%   96.73%   +0.16%     
==========================================
  Files          13       13              
  Lines        1136     1164      +28     
==========================================
+ Hits         1097     1126      +29     
+ Misses         39       38       -1
Impacted Files Coverage Δ
mopidy_spotify/translator.py 96.23% <100%> (+0.3%) :arrow_up:
mopidy_spotify/browse.py 92.07% <95.65%> (+2.79%) :arrow_up:
mopidy_spotify/web.py 96.04% <0%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16de1e5...42f06b9. Read the comment docs.

kingosticks commented 4 years ago

Maybe I got a bit carried away here but I've changed all the 'full' model web translators to call the Ref translators and tested just the Ref translators.