search

mopidy / mopidy-spotify

Mopidy extension for playing music from Spotify
https://mopidy.com/ext/spotify/
Apache License 2.0
933 stars 109 forks source link

Initial support for saving Spotify playlists. #250

Closed fatg3erman closed 4 years ago

fatg3erman commented 4 years ago

This adds support for the 'save' function in playlists.py, using the web api client.

Pretty simple stuff, just had to add an extra parameter so I could force it to refresh the playlist after the save, otherwise it returned the cached copy which made it appear to a mopidy client that nothing had happened.

fatg3erman commented 4 years ago

OK I've had enough now. I don't understand why 'black' is failing and it won't tell me.

If someone can tell me if you're interested in merging this and explain why it's failing, I'll finish it.

kingosticks commented 4 years ago

Is this radical different to the other or here that aims to do the same thing?

fatg3erman commented 4 years ago

Ha! Sorry I didn't even notice the other one!

This attempts to do the same thing - in fact the other one does it better by atomizing the changes. However, the other one clears the cache to work around the caching issue, whereas this one adds a new use_cache parameter to get_one() which allows us to refresh just the one playlist while keeping the rest of the cache intact. That said, on thinking about it, I think that might not work because the old version will still be in the cache next time it gets looked up.

Currently suffering with insomnia. This is the result of early-morning boredom :) Perhaps best to ignore this.

fatg3erman commented 4 years ago

Yeah, this is actually not very good. Sorry for the bother.