kingosticks commented 4 years ago

This is #269 with the remaining CI fixes. And also with the held buffer changed from a global to an instance variable as the music_delivery_callback tests were no longer doing the right thing.

codecov[bot] commented 4 years ago

Codecov Report

Merging #277 (0ac120d) into master (d77a73b) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   96.64%   96.67%   +0.03%     
==========================================
  Files          13       13              
  Lines        1191     1203      +12     
==========================================
+ Hits         1151     1163      +12     
  Misses         40       40

Impacted Files	Coverage Δ
mopidy_spotify/playback.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d77a73b...0ac120d. Read the comment docs.

kingosticks commented 4 years ago

There is still https://github.com/mopidy/mopidy-spotify/pull/277/files#diff-d09e8ce8f0a316832307028fe46a8319R202 to think about. I think it's actually OK and the None condition is handled by our appsrc.

ArthaTi commented 4 years ago

Haven't noticed your PR before. I'm glad you fixed it and I think your solution should be okay.

jodal commented 3 years ago

After an hour or so on video with @kingosticks live-coding now, we've:

Made it thread-safe, in case someone changes track in the middle of doing an operation on the held buffer.
Made sure to hold on to the right buffer if the appsrc applies backpressure.

Should be ready to merge as soon as Nick is a bit more awake and confident enough :-)

ArthaTi commented 3 years ago

This is great news! Thank you!

mopidy / mopidy-spotify

Soaku gapless playback #277

Codecov Report