mopsicus / umi

Unity mobile input (UMI) plugin for Android and iOS, allows to use features of mobile native input fields
MIT License
398 stars 92 forks source link

Possible security issue #88

Closed pmabres closed 3 years ago

pmabres commented 3 years ago

We're getting a lot of debug messages including information about our input fields. Is there any way this information is being logged by the plugin itself? Example: 12-03 14:11:33.991 5820 6331 I Unity : Plugins receive data: {"name":"mobileinput","data":"{\"msg\":\"TEXT_END_EDIT\",\"text\":\"myemail@email.com\",\"id\":2}"} 12-03 14:11:33.991 5820 6331 I Unity : Mopsicus.Plugins.Plugins:OnDataReceive(String) 12-03 14:11:33.991 5820 6331 I Unity : 12-03 14:11:33.992 5820 6331 I Unity : MobileInput plugin OnData: { 12-03 14:11:33.992 5820 6331 I Unity : "name": "mobileinput", 12-03 14:11:33.992 5820 6331 I Unity : "data": "{\"msg\":\"TEXT_END_EDIT\",\"text\":\"myemail@email.com\",\"id\":2}" 12-03 14:11:33.992 5820 6331 I Unity : } 12-03 14:11:33.992 5820 6331 I Unity : Mopsicus.Plugins.MobileInput:OnData(JsonObject) 12-03 14:11:33.992 5820 6331 I Unity : Mopsicus.Plugins.Plugins:OnDataReceive(String) 12-03 14:11:33.992 5820 6331 I Unity : 12-03 14:11:33.992 5820 6331 I Unity : Plugins receive data: {"name":"mobileinput","data":"{\"msg\":\"ON_UNFOCUS\",\"id\":2}"} 12-03 14:11:33.992 5820 6331 I Unity : Mopsicus.Plugins.Plugins:OnDataReceive(String)

pmabres commented 3 years ago

Nevermind, I've found the class that is logging this, I'll just clone this repo and comment that out for now

MickGyver commented 2 years ago

@pmabres Can you please share what you did to fix this?

pmabres commented 2 years ago

To be honest I just cloned the repo and found every Debug.Log and Debug.LogError line and commented them out. Specifically on these two files:

https://github.com/mopsicus/UnityMobileInput/blob/master/Runtime/Plugins.cs https://github.com/mopsicus/UnityMobileInput/blob/master/Runtime/MobileInput.cs

Main issue is that libraries like Sentry do error reporting and they grab some of the non error logs, so having sentry printing out plain text passwords wasn't the most desirable choice =P

MickGyver commented 2 years ago

Thank you @pmabres for the insight, much appreciated!