mopsy14 / Minecraft-Discord-Statusbot

A Discord bot, that will come online when your Minecraft server is online, and much more!
Other
9 stars 0 forks source link

A lot of deprecated stuff, can't edit the code, closed source from license. #11

Open SkyFoxCoder opened 1 week ago

SkyFoxCoder commented 1 week ago

What's the point of publishing part of the code on github if it's to make it closed source in terms of licensing? (license file says "All rights reserved"). The code is basically unusable even if it's on github, because of the license.

I would probably contribute if the code was complete (even the plugin.yml is missing). There's is a lot of outdated ways of doing things that should be updated. Some of them are clearly stated in the Console on every launch of a server with that plugin.

Would it be possible to address those points? Thanks in advance :) SkyFoxCoder

mopsy14 commented 1 week ago

The license is from way back when I started this project and had absolutely no clue what license to use. So I used the simplest license back then. But I agree it is time to change that, I will take a look at it and change it.

The plugin.yml file should be there, are you certain you are in the correct branch?

And what the deprication concerns, the only really depricated thing I know about is the use of system.out instead of a logger. The reason for this is that it is easier to get compatible between different modloaders, as they all support the use of system.out. It might be possible to create a print method in the main class and then create an implementation on each modloader that uses a logger if possible.

If there are other things you are concerned about please let me know.