search

moq-wg / moq-transport

draft-ietf-moq-transport
Other
84 stars 22 forks source link

enum types have inconsistent numbering #468

Open afrind opened 4 months ago

afrind commented 4 months ago

Role, Subscribe Filter = start at 0x1 Setup Params, Object Status, Track Status codes, Subscribe Done, other error codes = start at 0x0

kixelated commented 4 months ago

ROLE starts at 1 too

fluffy commented 4 months ago

In general, I think it is really nice to have a value defined as Invalid and that will never be used by the enum or extension. That value is often zero. Agree we should be consistent and don't really care much one way or another. (and if you receive an enum with this value, it is a protcol error ).

ianswett commented 4 months ago

Shall I create a bikeshed label now?

afrind commented 3 months ago

Individual Comment:

I'll note that Role has a reason to start at 1 -- Pub (0x01) | Sub (0x02) = PubSub (0x03).

afrind commented 1 month ago

Stream Types are currently

DATAGRAM=1, TRACK=2, SUBGROUP=4

ianswett commented 1 week ago

The plan is to park this for now, and then renumber everything towards the end.