search

moquette-io / moquette

Java MQTT lightweight broker
http://moquette-io.github.io/moquette/
Apache License 2.0
2.32k stars 818 forks source link

Increased timeout to fix build failure on slow GitHub build systems #843

Closed hylkevds closed 5 months ago

hylkevds commented 5 months ago

Builds are sometimes failing on the GH build systems due to a timeout. This PR increases those timeouts from 200ms to 300 ms and puts the actual value of the timeouts in a constant for easier access.

hylkevds commented 5 months ago

This is fine, just a suggestion on the constant to transform in a Duration which is more explicit express what is it.

Good idea! I did change a few int parameters to long, to avoid casting. It's a pity that CountDownLatch.await() doesn't accept a Duration, that would have been even cleaner :)