search

moqui / mantle-usl

Mantle Universal Service Library
http://www.moqui.org/mantle.html
Other
30 stars 61 forks source link

Add CommunicationEventContent Services #152

Closed hellozhangwei closed 4 years ago

danieltaylor-nz commented 4 years ago

I checked this out and ran it locally without issue. Would you consider adding some Communication Event Content to the demo data here?

https://github.com/moqui/HiveMind/blob/master/data/HiveMindDemoData.xml

danieltaylor-nz commented 4 years ago

I merged this, but unfortunately, I failed to request this change to be made first. So I implemented it myself in the following PR: https://github.com/moqui/mantle-usl/pull/154

hellozhangwei commented 4 years ago

I checked this out and ran it locally without issue. Would you consider adding some Communication Event Content to the demo data here?

https://github.com/moqui/HiveMind/blob/master/data/HiveMindDemoData.xml

Yes, but I think it's better we have the uploading event communication content implemented for Add/Edit/Reply Comment on TaskSummary screen

danieltaylor-nz commented 4 years ago

Yes, I saw that too. There was no easy way for me to test your PR as there was no demo data with content, and no easy way to add content.

hellozhangwei commented 4 years ago

Please check PR https://github.com/moqui/HiveMind/pull/35