Please use "nowTimestamp" instead of ec.user.nowTimestamp"

moqui / mantle-usl

Mantle Universal Service Library

http://www.moqui.org/mantle.html

Other

29 stars 61 forks source link

Please use "nowTimestamp" instead of ec.user.nowTimestamp" #182

Closed eigood closed 2 years ago

eigood commented 2 years ago

https://github.com/moqui/mantle-usl/blob/9d46e1ee0bb6bd1b652e4600e3afface48f83443/service/mantle/product/SubscriptionServices.xml#L144

The rest of the lines in this method use nowTimestamp, which is a local variable. Calling ec.user.nowTimestamp creates a new value each time. This was changed when the MR we submitted was slightly refactored.

jonesde commented 2 years ago

This issue confuses me, there is no local nowTimestamp field in that service, though I see you added one in your related PR, #183, so I'll just close this... feel free to reopen if I'm reading this wrong.