search

moqui / moqui-framework

Use Moqui Framework to build enterprise applications based on Java. It includes tools for databases (relational, graph, document), local and web services, web and other UI with screens and forms, security, file/resource access, scripts, templates, l10n, caching, logging, search, rules, workflow, multi-instance, and integration.
http://www.moqui.org
Other
279 stars 200 forks source link

Remove myaddons.xml from .gitignore #542

Closed acetousk closed 2 years ago

acetousk commented 2 years ago

When making a fork, the first thing that someone should do is add a myaddons.xml file so that they can use gradle for getting their forked git repos. Having a .gitignore makes sense for the main branch, but for forked repos (which is the expected way to use moqui) it doesn't make sense.

Feel free to explain why this argument doesn't makes sense, but this is just a quality of life thing that I think will help make Moqui better.

jonesde commented 2 years ago

Yeah, this is a tough decision. The risk is that a myaddons.xml file will be added without a mechanism to prevent it other than human diligence. As you point out removing it from .gitignire is an extra step when creating a stabilization branch that you need a myaddons.xml file in, though that is only needed once per stabilization fork.

The consequences of accidentally adding a myaddons.xml file are fairly small, merge conflicts and such until it is fixed, so sure... might as well let it go.