Docker-Image-Pull Feature

[rohitpawar2811]

I have created the Docker-Image-Pull feature in which on clicking the INIT button it will fetch the Docker image mentioned according to credentials and also init Initialise instance in Async,by refresh you can check the status.

• Changes have been verified for : AWS ,Docker-Hub ,Azure Registry
• And Registry-Location: it contains the Registry-server-address now.
• In the case of Aws-Ecr registry in the password we have to give cmd(aws ecr get-login-password --region us-east-1) for generating token and on the host system must aws configured by access id and secret key

Updated Changes :

• suggested by @dixitdeepak : Created a field named authTokenCmd into moqui.server.instance.InstanceImage and then we can check based on that if authTokenCmd is not empty then go for that, otherwise use the password for authentication, From this way we can make it more generic and other registries like aws (which generates tokens different each time by using cmd) can easily be configured.

EX-:

• Docker-Hub : https://index.docker.io/v1/
• AWS-ECR-registry-server-address :[https://118728153888.dkr.ecr.us-east-1.amazonaws.com/v2/]
• AZURE -REGISTRY -: rohitmkj.azurecr.io

[rohitpawar2811]

Docker-Images-Pulling-Instructions -: For configuring images ,whose instance we have to create and firstly we have to configure credentials ,from where we have to fetch/pull images.
-And after following things just create an instance and select the image , which you have created. configuration point for image and registry in moqui.server.instance.InstanceImage Instance-Image-Id : Must-be-unique-name/PK your choice Image-Type-ID -: it's our choice of categorization Host-Type-Id -: it's our choice of categorization Image-Name - full-name of image must be given serveraddress/image-name:tag EX-:

• Aws : 118728153888.dkr.ecr.us-east-1.amazonaws.com/tk
• Azure : rohitmkj.azurecr.io/moquil
• Docker-Hub :- rohitroax123/moquil:latest
• Docker-container-Private-registry : localhost:5000/moquil:latest

Registry-Location : it contains the Registry-server-address now.

• Docker-container-private-registry : http://localhost:5000/v2/
• Docker-Hub : https://index.docker.io/v1/
• AWS-ECR-registry-server-address :[https://118728153888.dkr.ecr.us-east-1.amazonaws.com/v2/]
• AZURE -REGISTRY -: rohitmkj.azurecr.io

Username : Name of user from which we can login to docker . Password : password/ command(aws ecr get-login-password --region us-east-1) in case of Aws (through which token is generated)

[jonesde]

I apologize for the long delay reviewing this. The changes look good so there is just one thing missing: adding yourself to the AUTHORS file to take more formal credit for your changes, and to grant others clear permission to use them.

There are 2 sections in the AUTHORS file to sign by adding your legal name and github username like the others, and it must be a commit from the named GitHub account. There is one section for the CC0 license and one for the patent disclaimer in addition to the copyright disclaimer for CC0.

[rohitpawar2811]

@dixitdeepak I have revised the changes as you suggested to me, thank you for suggestions.

[rohitpawar2811]

I apologize for the long delay reviewing this. The changes look good so there is just one thing missing: adding yourself to the AUTHORS file to take more formal credit for your changes, and to grant others clear permission to use them.

There are 2 sections in the AUTHORS file to sign by adding your legal name and github username like the others, and it must be a commit from the named GitHub account. There is one section for the CC0 license and one for the patent disclaimer in addition to the copyright disclaimer for CC0.

@jonesde I have added Authors file as you said ,Thank you!

[rohitpawar2811]

@jonesde Anything wrong with my changes?