moqui / moqui-framework

Use Moqui Framework to build enterprise applications based on Java. It includes tools for databases (relational, graph, document), local and web services, web and other UI with screens and forms, security, file/resource access, scripts, templates, l10n, caching, logging, search, rules, workflow, multi-instance, and integration.
http://www.moqui.org
Other
279 stars 200 forks source link

Add relationship called children to EnumerationType #562

Closed acetousk closed 1 year ago

acetousk commented 1 year ago

This is probably missing and would be useful for not having to do additional entity finds for the EnumerationType entity

jonesde commented 1 year ago

The definition looks good, not sure about the short-alias 'children'. This is following a type many relationship between EnumerationType and Enumeration, ie getting all enum records by type. For type many short-alias values the convention is to use a plural word, singular for type one (and one-nofk). In this case maybe 'enums' would be a more descriptive yet short alias?

When I first saw the PR description with 'children' I was thinking maybe for hierarchical types, but EnumerationType doesn't have that. For what it's worth, when I think of children in a relational data model I usually think of a relationship between records of the same entity, like with parentWorkEffortId and the parent/child relationships with it.

acetousk commented 1 year ago

The definition looks good, not sure about the short-alias 'children'. This is following a type many relationship between EnumerationType and Enumeration, ie getting all enum records by type. For type many short-alias values the convention is to use a plural word, singular for type one (and one-nofk). In this case maybe 'enums' would be a more descriptive yet short alias?

When I first saw the PR description with 'children' I was thinking maybe for hierarchical types, but EnumerationType doesn't have that. For what it's worth, when I think of children in a relational data model I usually think of a relationship between records of the same entity, like with parentWorkEffortId and the parent/child relationships with it.

I changed children to enums.