moqui / moqui-framework

Use Moqui Framework to build enterprise applications based on Java. It includes tools for databases (relational, graph, document), local and web services, web and other UI with screens and forms, security, file/resource access, scripts, templates, l10n, caching, logging, search, rules, workflow, multi-instance, and integration.
http://www.moqui.org
Other
279 stars 199 forks source link

Improved log4j2 configuration #629

Closed AyanF closed 6 months ago

AyanF commented 6 months ago

In the moqui-framework log4j2.xml configuration file, the Async Appender references the Console Appender and it is positioned before to the Console Appender, while the official log4j2 documentation states that -

The AsyncAppender should be configured after the appenders it references to allow it to shut down properly.

Reference - https://logging.apache.org/log4j/log4j-2.3.1/manual/appenders.html#AsyncAppender

Ideally the Async Appender should be placed after all the other Appenders.

jonesde commented 6 months ago

Looks good, thank you, merged.