search

moqui / moqui-runtime

The default runtime directory for Moqui Framework
Other
37 stars 79 forks source link

Add necessary seed data, Get Party Profile Detail working, and added … #202

Closed acetousk closed 2 years ago

acetousk commented 2 years ago

In a screen xml document form there can be a drop down field. When a drop down has both allow-multiple and submit-on-select, I noticed that when the the x is pressed, the a transition is not called vs when an item is selected in a drop down list a transition is called (see video). This fixes it.

Screencast from 09-22-2022 03:51:01 PM.webm

jonesde commented 2 years ago

Thank you Michael, interesting, submit on remove too... I think that's fine, and by another way of looking at it a good fix. I hadn't thought about doing this before.

FWIW, the original intent of submit on select was for single-dropdown forms (ie only a single dropdown field on the form) that are used for navigation or other particular quick-action sorts of things. It can be used on other forms, and I'm guessing you're doing something a bit different with it, and that's great.

jonesde commented 2 years ago

On a side note, the one thing I'd do differently is remove some of the now redundant comments. It's great that you added references in comments to the other method that does something similar, and with those sorts of referential comments IMO it isn't necessary to repeat comments like those (about why a particular thing is done and the alternatives that were tried).