Open morajabi opened 7 years ago
Great! I think Jest is simplest method with awesome features out-of-the-box! If you have any questions mention me.
Hope, I haven't stepped on anyone's toes, but I just went ahead and started writing the tests. @morajabi Maybe you could merge my first PR ahead of them, so you could "test" if your build workflow with rollup is really still working with npm. Had to add react & react-dom (same versions as in styled-components, speaking newest 16.6.0) to devDependencies for the tests to run.
@timhagn No, you haven't stepped on anyone's toes! 😄🙌
@morajabi Puh, now I'm relieved ^^. Just thought, because @brajabi wanted to do this in July, there might be a conflict of interest ; ).
Is this and my PR #15 stale or still welcome? Also, how shall it interact and be merged with #16 pertaining #3? Questions above questions ^^.
@timhagn Surely welcome, why not? I'm not sure, should we merge #15 first or #16?
Hi @morajabi,
though I'm quite new to TypeScript, I like the work @franky47 put into #16. But as was pointed out in the first comment of PR #16 maybe #15 should be merged first, methinks.
What do the others think?
(And I just asked if this issue / #15 were now stale, cause of the time lag ; ).
Opened a new PR #19 with updated tests bringing them to 100% coverage : )
Maybe I can take this? @morajabi Why did you choose Jest?