search

morajabi / styled-media-query

💅💍 Better media queries for styled-component
MIT License
1.32k stars 53 forks source link

Updated Styled Components to 4.0.2, Babel to 7.1.2 #14

Closed timhagn closed 5 years ago

timhagn commented 5 years ago

First of all, great module, I really like using it with Styled Components!

In preparation for writing the tests with jest, it came to me, that some dependencies were quite outdated - especially now that styled-components is @ 4.0.2. So I did the following:

And some smaller changes, as you can see in the commits.

With all this I wanted to:

  1. Bump all to the latest versions
  2. Prepare for writing the tests in jest

I tested the build process and integrated it in a gatsby page with no problems occuring.

This will prepare for: Tackling Issue #1 - If it's at your convenience.

morajabi commented 5 years ago

It looks good! I will try to merge this in later today! Are we sure with peerDep versions? Many people aren't at latest React and might get a little warning from NPM / Yarn cli.

timhagn commented 5 years ago

Thanks : ). And if they want to use the latest styled-components, they should be, cause there react / react-dom is a dev-Dependency: https://github.com/styled-components/styled-components/blob/master/package.json - so I guess, we are in the clear.

aureliome commented 5 years ago

Good job @timhagn , I'm waiting this merge with trepidation :)

timhagn commented 5 years ago

@aureliome Thanks : )! Did you choose the word "trepidation" for Halloween? Cause translated to German it would mean something like "anxiety", "fearfulness" or the like ^^. One never stops learning. But @morajabi, did you already get the chance to look into merging it (or the tests in #14, for what it's worth)? I'm already using the updated versions in a soon to be production environment with no issues (putting "styled-media-query": "https://github.com/timhagn/styled-media-query#th-jest-tests" in my package.json for the time being ; ).

franky47 commented 5 years ago

I'm really interested in this merge as well ! I'm using styled-components v4 with TypeScript, I'll give this branch a go in the mean time.

morajabi commented 5 years ago

@timhagn Could you please change the version range like @ApacheEx commented above? Otherwise LGTM :)

timhagn commented 5 years ago

For all waiting for an answer, my main workstations Motherboard crashed yesterday and I'm just trying to get back on track with my Dev-Laptop -.- Sorry for the inconvenience, will try to resolve the requested changes as soon as possible % ).

morajabi commented 5 years ago

No worries @timhagn! It's open source and we're here to learn and have fun 👋 hope the machine gets alright soon!

timhagn commented 5 years ago

Although my main workstation is still down: Finally! Finalmente! Endlich! Squashed all changes done before into one commit and integrated all your suggestions. LGTM : )! (Used my Dev-Laptop ; ).

ApacheEx commented 5 years ago

I have removed package-lock.json and also unnecessary blank line in .babelrc.json, now it looks good for me. Thank you a lot 🥇

p.s. @morajabi I think it's ready to merge

morajabi commented 5 years ago

@ApacheEx Nice! @timhagn Thanks a lot for the hard work, I'm excited to merge and release this :D

timhagn commented 5 years ago

@ApacheEx Thanks for these changes! I'm only irritated a bit about the removal of the "unnecessary blank line, as I added it upon your request ^^. @morajabi Thanks, was a pleasure : ). As I'm using styled-media-query to ease my life right now, I'd have some ideas on API v3 - but LGTM first ; ).

timhagn commented 5 years ago

Any updates on this merge? Just asking ; ).

morajabi commented 5 years ago

First, my apologies for the merging taking so long! It's now published as v2.1.0 🎷 Second, thanks Tim for the PRs, I just invited you to the repository as a collaborator. Although you already have helped with the project, I'd like to have you as a collaborator. This means you can review and manage PRs or issues or even merge PRs when you or the collaborators, or I agree on.

timhagn commented 5 years ago

Nice! That's greats news on the merge and me now being a contributor. Thanks a lot, gonna use it responsibly : ). And so happy, that I now don't have to integrate my repo in my package.json ^^.

ApacheEx commented 5 years ago

@morajabi,

I get this error after upgrading, seems github release is missing. image

morajabi commented 5 years ago

@ApacheEx Forgot to push the GH tags, but how does that make the build fail? I thought NPM doesn't depend on these.

ApacheEx commented 5 years ago

I'm still faced this issue, is it only me? image

timhagn commented 5 years ago

Nope, it isn't only you, @ApacheEx, I just tried it and getting the same result -.- Shouldn't there be a dist folder in the npm package, or how do you finalize the build process, @morajabi? Hope I didn't break it % ).

morajabi commented 5 years ago

Wait, I think I found the cause.

morajabi commented 5 years ago

@timhagn @ApacheEx it should be fixed 🙈

ApacheEx commented 5 years ago

yeah, works now. Thank you guys

timhagn commented 5 years ago

@morajabi @ApacheEx Yup 2.1.1 is working and has a dist folder ^^. Thanks! P.S.: What was the problem's source, if you'd indulge, @morajabi?

morajabi commented 5 years ago

@timhagn Someone forgot to run yarn build before publishing 😅 (me)