fix(definition-types): accept custom string for all functions

morajabi / styled-media-query

💅💍 Better media queries for styled-component

MIT License

1.32k stars 53 forks source link

fix(definition-types): accept custom string for all functions #26

Closed raulfdm closed 4 years ago

raulfdm commented 4 years ago

Closes #23 #21

Description

This PR adds a function overload for media.* functions that allow we pass a custom size via string or a specific media query name.

First implementation

Secondimplementation

Result in VSCode

KesleyDavid commented 4 years ago

Good morning folks, any release forecast? I'm in the middle of a project, when I started coding the responsive I discovered this detail

larissaiurk commented 3 years ago

Hii! Thanks so much for this!

Seems like the PR for accept custom string has been merged, would it be possible to do a new release with those changes? Or already released and I didn't see...

raulfdm commented 3 years ago

Hey @larissaiurk .

To be really honest I think this package is not being maintained anymore.

Last year I'd merge a PR to solve that and it's indeed missing the release. Despite the fact I'm set as a contributor, I cannot make releases. I've made a proposal of automating this flow (here https://github.com/morajabi/styled-media-query/issues/27) but it never got answered.

https://github.com/morajabi/styled-media-query/issues/23#issuecomment-678968738

KesleyDavid commented 3 years ago

Hey, @larissaiurk @raulfdm I made an update and the necessary adjustments to work correctly in the typescript and made a publication. I was only using it for my projects, but if you want to use it too

https://www.npmjs.com/package/styled-query