moraroy / NonSteamLaunchers-On-Steam-Deck

Installs the latest GE-Proton and Installs Non Steam Launchers under 1 Proton prefix folder and adds them to your steam library. Installs... Battle.net, Epic Games, Ubisoft, GOG, EA App, Amazon Games, itch.io , Legacy Games, The Humble Games Collection, IndieGala, Rockstar Games Launcher, Glyph & VK Play. SD Card Support and Games.
https://github.com/sponsors/moraroy
MIT License
2.09k stars 44 forks source link

Launchers are not adding to Steam Library #256

Open imsofresh54 opened 1 month ago

imsofresh54 commented 1 month ago

After running script, EA Play is launching, but shortcut is not added to Steam Library.

Tryed doing restart, disabling NSL, separating APP IDs, using decky loader plugin. Nothing helps.

moraroy commented 1 month ago

@imsofresh54 are you installing to the sd card?

imsofresh54 commented 1 month ago

@imsofresh54 are you installing to the sd card?

Nope, on internal SSD

moldof97 commented 1 month ago

Hi, I hope this might be of help, I was tweaking a bit and when doing a fresh start after a while I encountered the same problem, tried reinstalling again and again but with no result. I read some old closed issues where it said it might fix doing a log out from the steam account and closing the application then restarting the device and logging in again. tried that, reinstalled NSL and the launchers were added in the library

imsofresh54 commented 1 month ago

Hi, I hope this might be of help, I was tweaking a bit and when doing a fresh start after a while I encountered the same problem, tried reinstalling again and again but with no result. I read some old closed issues where it said it might fix doing a log out from the steam account and closing the application then restarting the device and logging in again. tried that, reinstalled NSL and the launchers were added in the library

Thank you for answer, but no luck for me. 😢

imsofresh54 commented 1 month ago

I found what was an issue. After fresh install of Steam OS, and installing NSL, nothing seems to work. But later i entered gaming mode, and in non-steam section i was promted to download Google Chrome. After i done this, and restarting NSL, launchers appeared in library.

moraroy commented 1 month ago

@imsofresh54 interesting ok.. will take a look at the logic @moldof97

rafal-zelek commented 1 month ago

I had the same issue on my fresh steamOS. Adding chrome like guy above said fixed the issue.

theimpulson commented 1 month ago

Just had the same issue. Installing Chrome first and restarting NSL afterwards fixed it.

cgiraldo commented 1 month ago

I also hit this in a fresh steamOS install. The error in log is:

['/home/deck/Downloads/NonSteamLaunchersInstallation/lib/python3.11/site-packages', '/home/deck/.config/systemd/user/Modules', '/home/deck/.config/systemd/user/Modules', '/home/deck/.config/systemd/user', '/home/deck/Downloads/NonSteamLaunchersInstallation/lib/python3.11/site-packages', '/home/deck', '/usr/lib/python311.zip', '/usr/lib/python3.11', '/usr/lib/python3.11/lib-dynload', '/usr/lib/python3.11/site-packages']
Traceback (most recent call last):
  File "/home/deck/.config/systemd/user/NSLGameScanner.py", line 406, in <module>
    create_new_entry(os.environ.get('epicshortcutdirectory'), 'Epic Games', os.environ.get('epiclaunchoptions'), os.environ.get('epicstartingdir'))
  File "/home/deck/.config/systemd/user/NSLGameScanner.py", line 366, in create_new_entry
    if check_if_shortcut_exists(signed_shortcut_id, appname, exe_path, startingdir, launchoptions):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/deck/.config/systemd/user/NSLGameScanner.py", line 324, in check_if_shortcut_exists
    if any(s.get('appid') == shortcut_id for s in shortcuts['shortcuts'].values()):

NSLGameScanner.py does not check for an empty shortcuts.vdf file. As @imsofresh54 did with Chrome, a work-around is to add any non-steam product before running the script (I just add "Ark" as non-steam app).

moraroy commented 1 month ago

@cgiraldo dang ok thank you for providing the error log that explains alot, unfortunately I can't put in a fix just yet as I have irl things going on. I'll try to apply a fix perhaps this weekend.

ckhan101 commented 1 month ago

yep same here - got new steam deck last week and had same issue as @cgiraldo with nothing being added to steam and random behaviour (some launchers opening in desktop, most not). I will strart fresh after installing chrome to see if that works..!!