moraroy / NonSteamLaunchers-On-Steam-Deck

Installs the latest UMU/GE-Proton and Non Steam Launchers under 1 Proton prefix folder and adds them to your steam library. Installs... Battle.net, Epic Games, Ubisoft, GOG, EA App, Amazon Games, itch.io , Legacy Games, The Humble Games Collection, IndieGala, Rockstar Games Launcher,PS Plus, Glyph, VKPlay & HoYoPlay. SD Card Support and Games.
https://github.com/sponsors/moraroy
MIT License
2.75k stars 50 forks source link

Add a download button for lay users in the Readme file #33

Closed Heus-Sueh closed 1 year ago

Heus-Sueh commented 1 year ago

same as decky-loader Readme button we could ask if we can use this image of them image

Decky Loader Readme RAW

moraroy commented 1 year ago

Thank you @Heus-Sueh for the suggestion! @cchrkk what do you think should we add that? Also thank you brother for the Kofi! I saw it on my email you didn't have to! I should be giving you the cup of coffee lol. Another thing on my mind as well, the log file is good I like it makes it very easy but I noticed a problem. I ran the script like 20 times yesterday trying to test some things and I noticed the log file "builds" and gets bigger with code. When steam restarts the log seems to keep logging even after the script is finished. It may be because I need to put an "exit" at the end of the script not sure if that's the problem or not... what do you think?

cchrkk commented 1 year ago

Here we go 👌👌 https://github.com/moraroy/NonSteamLaunchers-On-Steam-Deck/pull/35 I knew there was a way to make a button to auto download it, i'm too noob to undestand stuff :D

@moraroy don't worry bro, your script idea is super handy and convenient. You're super invested into fixing issues and implementing stuff and u deserved a coffee 💯

Try to add exit and see, I know zero of programming not even bash, I'm just a geek 🤣

cchrkk commented 1 year ago

I just noticed it's not working anymore, to be able to download the desktop file instead of opening it in the browser, you must link to some file in the Release section. So you probably need to create a new repository and release the .desktop file there, then link it. 😒 Why is it so hard to link and download a file

cchrkk commented 1 year ago

Fixed temporarily by #36 but maybe you want to create a DL repository yourself

moraroy commented 1 year ago

@cchrkk nice work! Yeah I noticed that too but I'm thinking maybe we won't need the .desktop file anymore since we have that button now.. but in the end I guess the more ways to download the better?

moraroy commented 1 year ago

@cchrkk thats a tight logo BRO!!!!! <3

cchrkk commented 1 year ago

@cchrkk nice work! Yeah I noticed that too but I'm thinking maybe we won't need the .desktop file anymore since we have that button now.. but in the end I guess the more ways to download the better?

Uhm, that button is linked to the desktop file 😂 That button didn't work for the last 20 hours.

@cchrkk thats a tight logo BRO!!!!! <3

Thank you :) spent a good hour for that

Heus-Sueh commented 1 year ago

thanks :+1: @cchrkk