moraroy / NonSteamLaunchers-On-Steam-Deck

Installs the latest GE-Proton and Installs Non Steam Launchers under 1 Proton prefix folder and adds them to your steam library. Installs... Battle.net, Epic Games, Ubisoft, GOG, EA App, Amazon Games, itch.io , Legacy Games, The Humble Games Collection, IndieGala, Rockstar Games Launcher,PS Plus, Glyph, VKPlay & HoYoPlay. SD Card Support and Games.
https://github.com/sponsors/moraroy
MIT License
2.71k stars 50 forks source link

Epic Games DLC shows up in Steam games list #399

Closed Kosai106 closed 2 months ago

Kosai106 commented 2 months ago

Maybe I missed some configuration but I recently updated to the latest version of the tool, and now my DLC for Hitman 3 has started to show up as individual games in Steam even though they shouldn't.

It's a bit frustrating and time consuming to remove them after each time I run NonSteamLaunchers.

(Sorry for being lazy and not taking a direct screenshot)

Example
Example: Click to see full size

moraroy commented 2 months ago

@Kosai106 wow thats alot, and this is for epic games launcher correct?

moraroy commented 2 months ago

@Kosai106 and youre on plugin or desktop?

Kosai106 commented 2 months ago

@moraroy Yeah it's a bit much lol. And yes it's for the Epic Games Launcher.

I've primarily used the desktop script which causes this, but I just confirmed the issue also happens when using the plugin version.

moraroy commented 2 months ago

@Kosai106 ok thank you, basically the NSLGameScanner.py in the desktop and the NSLGameScanner.py needs more logic to prevent those for the epic games launcher, ill do my best over the next days to fix it, if you use the plugin try to use manual scan for now i guess

Kosai106 commented 2 months ago

@moraroy No worries, thanks. I'm not very familiar with Python but let me know if I can be of assistance in some way.

moraroy commented 2 months ago

@Kosai106 hey brother, let me know if that fix helped, i just updated the desktop version. Hit Stop Scanner and then when it asks to restart press yes and that should let the scanner update to the latest fix, make sure you delete your other entries to test even the orginal game to make sure i didnt break anything

Kosai106 commented 2 months ago

@moraroy Hiya, just tested and it works partially!

It stopped adding back the individual maps from Hitman 3, such as "Berlin" or "Chongqing" which is nice. The DLC such as the "Seven Deadly Sins" acts still gets picked up. Basically the ones from the screenshot are still being detected, the map ones are not shown on there, but they're no longer an issue anyway, hah.

Not sure if any of that is coherent, but let me know.

Edit:// I might have spoken too soon - It seems to actually work now. Maybe those were left over from before haha. Thanks so much man, I appreciate it! ❤️