morassman / atom-commander

Dual-pane file manager for Atom.
MIT License
33 stars 5 forks source link

Description - wrong key-combination #67

Closed leomayer closed 7 years ago

leomayer commented 7 years ago

For opening a panel you write in the summary CTRL-T On my Linux-system this is CTRL-t

Same applies to remove a panel: CTRL-R ==> CTRL-r

morassman commented 7 years ago

Strange... This doesn't seem to be a problem on OSX and Windows. I'll make change it to not be case-sensitive.

What distribution of Linux are you using?

leomayer commented 7 years ago

OpenSuSe 42.1 But could be as well due to other installed packages - don't know. Cuz when I look on the Keybindings and search for CTRL-R it will list only CTRL-r and there I have two bindings - one for Atom Commander and one for Symbol View with Selector (.platform-linux atom-text-editor) and Command (symbols-view:toggle-file-symbols). Key-mapping-conflict?

morassman commented 7 years ago

It may be a key-mapping conflict. I'll look into it.

morassman commented 7 years ago

In atom-commander's keymaps file the shortcuts are specified as:

'ctrl-t': 'atom-commander:add-tab'
'ctrl-r': 'atom-commander:remove-tab'

As far as I know this should work with either 't' or 'T'.

I tried this myself and things worked as I expected. When the editor has focus and I press ctrl-r then the symbols view's command is triggered. When atom-commander has focus then its remove tab command is triggered.

Do you have this problem even when atom-commander has focus?

leomayer commented 7 years ago

Hmmm... retesting your last comment and the whole thing turns out in a strange way.

First of all - no probs when atom-commander has the focus ... seems like it was some kind of focusing issue :-/

BUT the strange things start to happen when I have the focus in the 'address bar'. CTRL-t worx but when I'm on the right side => a tab is added on the left side ! (instead of the right) CTRL-r does NOT work (neither left nor right) when focus is in the address bar.

morassman commented 7 years ago

Aaah. I know what's happening.

Ctrl-t Ctrl-t add a tab to the panel (left/right) that has focus, but the focus doesn't change when one select the address bar. I'll have to fix this.

You can confirm it like so:

If you select the left panel first and then the right address bar, then the tab will be on the left.

Ctrl-r I looked into this and I think it can be solved by associating the shortcut key with a nested selector. The Ctrl-r is bound to the text editor where you edit files, but the address bar uses the same instance of such a text editor, just with a single line. So ctrl-r ends up triggering the command associated with the text editor and not atom-commander. I'll look into this as well.

leomayer commented 7 years ago

Reg. Ctrl-t: I can confirm that behaviour. When I follow your steps ==> it worx as you describe 👍

morassman commented 7 years ago

This should now be fixed as part of v0.9.0