update Sci_Position.h for N++ 8.2.2

vinsworldcom commented 2 years ago

Just updated Sci_Position.h file to see if this fixes the issue.

Fix #135

morbac commented 2 years ago

I've included the fix in release 3.1.1.11.

xomx commented 2 years ago

@morbac

This PR is incomplete. For your XMLTools plugin is not enough to update only the Sci_Position.h.

There are other problems in the plugin code in connection with the upcoming N++ 8.2.2+ support for 2GB+ files. One of them I mentioned here.

To reproduce the crash:

download a 8.2.2 RC5 x64 build of N++, e.g. this (edited: seems to this was deleted, so dl here instead)
add your latest patched 3.1.1.11 x64 plugin
start N++
open a 2GB+ text file (you can use e.g. this)
select menu Plugins -> XMLTools -> Pretty print
Plugin Crash msgbox: XMLTools.dll just crashed in runPluginCommand(size_t i : 36)

If you want to, I could tomorrow check the XMLTools plugin codebase for the remaining 2GB+ problematic parts and then create another PR to fix these problems.

morbac commented 2 years ago

The fix embedded in 3.1.1.11 was required to avoid crash on "small" files.

Now I agree with you that this patch is by far not sufficient for 2GB+ files. I did some checks tonight and I think I could identify the crash root cause. I'll try to fix it as soon as possible.

xomx commented 2 years ago

Ok. If you will need a tester, let me know. There is also this N++ plugintemplate Scintilla.h update. And thanks for your very useful plugin.

morbac commented 2 years ago

Work is in progress. I've built this first pre-version of 3.1.1.12 which fix some issues you observed with 2GB+ files:

3.1.1.12 alpha.zip

I still have to improve error report when annotation mode is selected. I also have to check that modifications have not negative impact on encoding support.

xomx commented 2 years ago

So far so good, no more crashing :-)

morbac / xmltools

update Sci_Position.h for N++ 8.2.2 #136