search

morbidick / stripe-elements

Stripe Web Components
10 stars 3 forks source link

Add loading property #10

Closed RoXuS closed 6 years ago

RoXuS commented 6 years ago

Hey !

Thx for your element !!

I just add a commit to display a loader while the token is created.

And an other commit to set displayError as a public method. Then, we will use the component to display the other errors from Stripe API.

morbidick commented 6 years ago

Hi, thanks for your PR. Just one thing, if we have displayError as public method we should add a check for Line 254 to not run into any errors where param is set with no matching form element. Would you mind adding another commit?

RoXuS commented 6 years ago

Hi @morbidick, Good catch, I have added the check, it is ok for you ?

RoXuS commented 6 years ago

Oh yeah sorry @morbidick, it's my IDE which auto format the code following my eslint conf ^^.

I rebase the last commit to avoid all whitespaces. It should be ok !

morbidick commented 6 years ago

Thank you very much @RoXuS, Im going to update analysis.json and push a new release.