search

mordak / Term48

50 stars 20 forks source link

Add basic Makefile and decouple from Momentics #18

Closed ardangelo closed 7 years ago

ardangelo commented 7 years ago

Hey, I'm not sure how you feel about Momentics, but I've done some work to get Term48 building and deploying without using Momentics (just BBNDK). I have some ideas for improvements to Term48 and plan on tinkering as time allows. Feel free to reject this PR if you feel that Momentics is the way to go for mainline Term48. Thanks, Andrew

mordak commented 7 years ago

Oh, I love this direction. Momentics is fine and all, but bootstrapping the build has always been painful. I am traveling this weekend, so might not be able to review this for a couple of days, but if it all works for me then I am happy to do the merge. Thanks!

mordak commented 7 years ago

So I love the way this looks, but it doesn't seem to create a working binary for me? I added some minor comments on signing/Makefile and on the bar-descriptor.xml for things that caused the deploy-token / build / deploy to fail. Once I fixed those up, then deploying the debug token worked great, and the build / deploy was fine. The resulting binary seemed non-functional though - It would launch, but I couldn't type. I tried swapping in the shared libraries (libconfig, SDL, TCO) from the Term48 release and the binary compiled / linked, but wouldn't launch once installed on the device. Not sure what's going on. Anyway, if we can fix up the minor things I commented on, and I can get a working binary at the end, then I am happy to merge. I really like this direction!

ardangelo commented 7 years ago

Hey, I had the same issue (not being able to type) on the master branch code. It could be related to the shared libraries; I figured I'd get a build system working before debugging issues. I'll fix up based on your suggestions tonight, thanks.

mordak commented 7 years ago

Adding in the terminfo and such is great. I'll give this another go tomorrow and see where we are. If you are also getting no input I'll see if I can figure out the difference between this build and the release. Thanks!

mordak commented 7 years ago

So far so good. I love adding in all the assets and stuff. Still doesn't make a working binary for me, but I'm going to merge this, and then we can figure out the making it run thing. :-) This is great work!