mordaroso / guard-motion

Guard::Motion automatically run your RubyMotion specs (much like autotest)
MIT License
45 stars 12 forks source link

Apparent API issue between guard-motion and growl notifications #5

Closed philomory closed 11 years ago

philomory commented 11 years ago

When I use guard-motion with the growl notifier for guard through the growl gem, I get the following error:

13:57:04 - ERROR - Error sending notification with growl: undefined methodtype=' for #`

This appears to be caused by your supplying a :type option Notifier.notify in runner.rb:47; Notifier.notify passes that option on in the options hash to Notifier::Growl.notify (notifier.rb:171), which in turn passes it on to Growl::Base.new (growl.rb:90), which attempts to call self.type= (growl.rb:148), which doesn't exist.

As far as I can tell there is no need to pass a :type option, as Notifier.notify sets type information based on the :image option (notifier.rb:165). According to the RDoc for Guard::Notifier, the :image option is the intended way to specify a type.

mordaroso commented 11 years ago

Fixed by #6