search

mordechairoth / IveltChromeExtension

Extension to add accessibility features to www.ivelt.com
8 stars 14 forks source link

Add google search #34

Closed mayim-chayim closed 3 years ago

mayim-chayim commented 3 years ago

@kavhayushar please review

kavhayushar commented 3 years ago

All in all, nice job. I would append the changes myself but I have no access to your branch, hence no access to modify the PR.

mayim-chayim commented 3 years ago

Therefore I suggest to concat the search term when hitting the search.

fixed moved the intitle before site: to avoid RTL issues

KnaperYaden commented 3 years ago

@mayim-chayim this is only Google Search "in thread".

Can you do the same idea as a main ivelt search. Something like this: image

(Also Google is usually spelled as גוגל, not גאאגל.)

mayim-chayim commented 3 years ago

@mayim-chayim this is only Google Search "in thread".

Can you do the same idea as a main ivelt search. Something like this:

I don't think that it is so important, because you can always do a site:ivelt.com, to search in a thread you need an additional intitle, with the RTL issues adding confusion maybe one day I will do it

(Also Google is usually spelled as גוגל, not גאאגל.)

Changed

KnaperYaden commented 3 years ago

I don't think that it is so important, because you can always do a site:ivelt.com, to search in a thread you need an additional intitle, with the RTL issues adding confusion

Correct, but whole site search is probably needed more often (or maybe just by me...)