Warn before losing unsubmitted post

mordechairoth / IveltChromeExtension

Extension to add accessibility features to www.ivelt.com

8 stars 14 forks source link

Warn before losing unsubmitted post #47

Closed nefshech closed 2 years ago

nefshech commented 2 years ago

Closes #45.

When clicking on any link or closing the browser, a warning will be displayed if there's unsubmitted text.
Unsubmitted text will be detected in the "new thread", "new post" or "quick post" forms.

kavhayushar commented 2 years ago

Since this is somewhat an intrusive behavior. I'm afraid we should first add an option to disable it before pushing it live. Option should be in Setting Page to Enable/Disable this feature.

nefshech commented 2 years ago

Since this is somewhat an intrusive behavior. I'm afraid we should first add an option to disable it before pushing it live. Option should be in Setting Page to Enable/Disable this feature.

Should this setting be released or only for testing purposes? I don't see a use case for this setting option (if tested properly)

kavhayushar commented 2 years ago

Of course released. Every user should have the option if he wants to have this functionality. We shouldn't force intrusive functionality on every user without the ability to opt-out.

I'm strongly for giving flexibility to users to turn on/off whichever feature they like/dislike.

nefshech commented 2 years ago

Makes sense, ok with me.

I was just comparing it to the keyboard shortcuts which we don't provide the option to opt out (even though some of them are overdone for some users) but I get it.

kavhayushar commented 2 years ago

@mordechairoth Should we wait for it, or make a run for it and add the settings later. So we don't miss the 1st update day?

mordechairoth commented 2 years ago

@kavhayushar We should wait until there is a settings page.

mordechairoth commented 2 years ago

@nefshech the reason we don't want this to be turned on by default is because some users may get annoyed by this feature as @kavhayushar already mentioned

nefshech commented 2 years ago

@mordechairoth Understood.

I will rush it if it can still get into the next release, otherwise it will be done in the next few days. Please let me know

mordechairoth commented 2 years ago

@nefshech Don't rush, I will Iy"h put it into next months release.

nefshech commented 2 years ago

Added a setting, ON by default.

bevekashaivelt commented 2 years ago

@mordechairoth this should have been pushed in the December release. This and #51 as well, for some reason these were not merged before the release. I think it's unfair to wait another month, for these features to be released. I think another update should be pushed.

kavhayushar commented 2 years ago

@nefshech Are you avail to resolve the new conflicts?

nefshech commented 2 years ago

@nefshech Are you avail to resolve the new conflicts?

Resolved.