search

mordentral / VRExpansionPlugin

A UE4-5 VR framework
https://www.vreue4.com
MIT License
522 stars 109 forks source link

Change VRBaseCharacter components to Optional subobjects #49

Closed ronaldburns closed 6 months ago

ronaldburns commented 6 months ago

This change proposes changing all the components of the VRBaseCharacter to Optional Subobjects.

Use case: I have AI that I'd like to share a lot of code with, but I don't want them to have any of the VR components.

All code using these components is already wrapped in if statements, so it's safe when they're nullptr in child classes.

mordentral commented 6 months ago

This is totally not safe with the entire code base assuming that the components exist. There WILL be code at some point that crashes out because of this, even if currently I have everything fully locked behind checks.

That being said, it has to be specifically done by something looking to do it, and can't be an accidental issue. So I don't really see the harm in letting people shoot themselves in the foot and seeing how far they get ;p.