mordrax / cotwelm

Castle of the Winds (A Remake in Elm)
http://game.castleofthewinds.com
103 stars 11 forks source link

fix grammar of hit message #6

Closed djuretic closed 7 years ago

djuretic commented 7 years ago

There were messages like this: "Hobgoblin hit the you for 6 damage!" I removed the extra "the" when you get attacked.

mordrax commented 7 years ago

While you're here, could you also fix the case of when a monster is the attacker, it should say "The hobgoblin hit you..." instead of "Hobgoblin hit you..."

Looks like it's a matter of putting "The" and lowercasing the monster name here: https://github.com/djuretic/cotwelm/blob/772ee382fdfb21f3d7bf87047aef6f932a310b6f/src/Game/Collision.elm#L148

djuretic commented 7 years ago

Done adding the extra 'The'.

About lowercasing the monster name, in the case of bosses (e.g. Hrugnir) it won't work very well (it is a proper noun). To keep it simple I'll suggest not to change the case of the mosters' name.

mordrax commented 7 years ago

That's a good point, let's see how it looks as is with capitalised monster names.

djuretic commented 7 years ago

Just look at the original game, it capitalized every monster name.