Allowing access to the OS version

moredip / Frank

Automated acceptance tests for native iOS apps

www.testingwithfrank.com

Apache License 2.0

1.21k stars 237 forks source link

Allowing access to the OS version #254

Closed seanoshea closed 11 years ago

seanoshea commented 11 years ago

Allowing access to the OS version

seanoshea commented 11 years ago

Awesome. Thanks.

moredip commented 11 years ago

Thanks @ondrejhanslik.

For future reference, I'd prefer us using the new obj-C literals for arrays and dicts. They are supported on all runtimes and reduce the amount of boilerplate quite a bit.

seanoshea commented 11 years ago

Happy to submit a new PR with literals. I was just sticking to the current syntax and didn't want to rock the boat too much with new syntax. I'd be the first to admit that I'm not all that familiar with mac development either, so I played it safe and just stuck with NSDictionary/NSArray syntax.

moredip commented 11 years ago

No worries. If you feel motivated I'd be very happy to take the PR.

seanoshea commented 11 years ago

Hey Pete. See https://github.com/moredip/Frank/pull/255 for an updated PR.