search

moreginger / xbmc-plugin.video.ted.talks

GNU General Public License v2.0
18 stars 20 forks source link

Problems getting intro duration for subtitles #20

Closed moreginger closed 12 years ago

moreginger commented 12 years ago

http://www.ted.com/talks/ken_robinson_changing_education_paradigms.html

The following error is logged when trying to play the talk with subs.

21:42:40 T:46234432  NOTICE: [TED Talks] resources.lib.model.fetcher attempting to open http://www.ted.com/talks/ken_robinson_changing_education_paradigms.html with data
21:42:40 T:46234432  NOTICE: [TED Talks] loaded cookie :  from /home/tim/.xbmc/temp/ted-cookies.lwp
21:42:42 T:46234432  NOTICE: [TED Talks] Could not determine intro duration for subtitles.

I think it doesn't have an intro, hence the problem.

moreginger commented 12 years ago

Actually this talk doesn't have subtitles at all. The code was allowing things to proceed when the languages attribute was not found in flashvars (since we don't technically need to know it is there to fetch subtitles). Made it more stringent in e7c3051d9712b1d8912293712600920fa90fee17.

moreginger commented 12 years ago

http://sourceforge.net/mailarchive/forum.php?thread_name=CAJMG0Wpe6zcS2-ktXcUX3K7HiP4zeL9WqTxQ%3D1A%2BsopsOUrWXA%40mail.gmail.com&forum_name=xbmc-addons