search

morehawes / open-currency-converter

💵 WordPress plugin to convert currencies within the text of a post or page.
https://wordpress.org/plugins/artiss-currency-converter/
GNU General Public License v2.0
2 stars 4 forks source link

PHP Warning – Use of undefined constant global_convert_from #29

Closed dartiss closed 4 years ago

dartiss commented 5 years ago

component: “Plugin: artiss-currency-converter” file: “wp-content/plugins/artiss-currency-converter/includes/convert-currency.php” line: 93 message: “Use of undefined constant global_convert_from – assumed ‘global_convert_from’ (this will throw an Error in a future version of PHP)”

https://wordpress.org/support/topic/php-warning-use-of-undefined-constant-global_convert_from/

saravana87 commented 5 years ago

It can be fixed by adding double quotes define ("global_convert_from")

Thanks

Matej4545 commented 4 years ago

Hi, could you please push a fix for this bug in the near future? As @saravana87 said, it can be simply fixed (ln 93 and 100 in convert-currency.php). It has been there since PHP 7.2 and I discovered that when combined with Elementor, it outputs the console message directly to the web, which is annoying at least. I quick-fixed it in source code, but I guess this could be an issue for the majority of the users.

dartiss commented 4 years ago

Hi @Matej4545 - I'll try and get this pushed out over the next week or two.

dartiss commented 4 years ago

@Matej4545 Released!