search

morehawes / open-currency-converter

💵 WordPress plugin to convert currencies within the text of a post or page.
https://wordpress.org/plugins/artiss-currency-converter/
GNU General Public License v2.0
2 stars 4 forks source link

Can no longer specify the API #38

Open dartiss opened 4 years ago

dartiss commented 4 years ago

Can no longer get the plugin to accept an API.

Grab an API from https://openexchangerates.org/account/app-ids

Accordind to OXR instructions (https://docs.openexchangerates.org/docs/authentication), the format is as follows - https://openexchangerates.org/api/latest.json?app_id=3e6bdfb263b9459b804cb63c4ed35774. This works.

I've checked my plugin and the is the URL it's using. I've rolled back to a much earlier version and it's the same, so it appears something else has changed here. It could either be the response coming back from OXR or a recent change to WordPress core.

aaronjpitts commented 4 years ago

Hi @dartiss. This seems to have broken the whole plugin and shows errors on my site. I've had to disable the convertor. If it cannot connect to the API, should you not just fall back to using the exchange rates cache instead of breaking completely?

Up until now everything has been running great with your plugin, so thank you for your work so far :)