morelinq / MoreLINQ

Extensions to LINQ to Objects
https://morelinq.github.io/
Apache License 2.0
3.63k stars 409 forks source link

Hide `ToDictionary()` in net8+ #1040

Closed viceroypenguin closed 7 months ago

viceroypenguin commented 7 months ago

This PR updates ToDictionary() to be hidden on net8, since the BCL has added a duplicate method.

Fixes #1012 Relates to #945

viceroypenguin commented 7 months ago

Now that #1041 is merged with 9a4ea61, can we resolve the conflicts so there's a smaller diff to review? Thanks!

Done!

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9a4ea61) 92.62% compared to head (c9144e4) 92.52%. Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1040 +/- ## ========================================== - Coverage 92.62% 92.52% -0.11% ========================================== Files 113 113 Lines 3419 3413 -6 Branches 1055 1058 +3 ========================================== - Hits 3167 3158 -9 Misses 189 189 - Partials 63 66 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.