search

morelinq / MoreLINQ

Extensions to LINQ to Objects
https://morelinq.github.io/
Apache License 2.0
3.67k stars 412 forks source link

Update to using C# 12 #1046

Closed atifaziz closed 10 months ago

atifaziz commented 10 months ago

This PR allows the use of the C# 12 going forward and updates the code base to take advantage of primary constructors and collection expressions to reduce ceremony.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9a4ea61) 92.62% compared to head (07434c2) 92.51%.

:exclamation: Current head 07434c2 differs from pull request most recent head 80ab81c. Consider uploading reports for the commit 80ab81c to get more accurate results

Files Patch % Lines
MoreLinq/Delegating.cs 62.50% 0 Missing and 3 partials :warning:
MoreLinq/ReverseComparer.cs 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1046 +/- ## ========================================== - Coverage 92.62% 92.51% -0.12% ========================================== Files 113 112 -1 Lines 3419 3405 -14 Branches 1055 1056 +1 ========================================== - Hits 3167 3150 -17 Misses 189 189 - Partials 63 66 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

atifaziz commented 10 months ago

Sorry, I didn't get a chance to review this yesterday. LGTM.

No worries and feel free to comment still if you see something, or better yet, open an issue to track.

I would add these four errors to the .editorconfig, though:

I don't it's needed since those warnings, or in fact all warnings, will be promoted to errors by the following default:

https://github.com/morelinq/MoreLINQ/blob/80ab81c9e06af0409e621ddeef7f83e4f4ebf0b9/Directory.Build.props#L5