search

morelinq / MoreLINQ

Extensions to LINQ to Objects
https://morelinq.github.io/
Apache License 2.0
3.63k stars 409 forks source link

Pin to .NET SDK 8.0.2xx #1069

Closed atifaziz closed 1 month ago

atifaziz commented 1 month ago

This PR pins the solution to .NET SDK 8.0.2xx. Up to now, the roll-forward policy was latest feature, but .NET SDK 8.0.300 introduces a regressions which causes compilation to fail due to the following code analysis errors:

bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(1,1): error IDE0240: Nullable directive is redundant (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0240)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(45,17): error IDE0010: Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(69,21): error IDE0010: Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(81,37): error IDE0010: Populate switch (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0010)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(86,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(92,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(98,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(104,45): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(113,33): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(119,29): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(133,37): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(139,33): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(145,29): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(155,33): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(161,29): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(170,17): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)
bld\ExtensionsGenerator\obj\Debug\net8.0\DocoptNet\DocoptNet.CodeGeneration.SourceGenerator\ProgramArguments.cs(176,13): error IDE0058: Expression value is never used (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0058)

To avoid being subjected to future regressions, it seems safer to roll-forward to latest patch only.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.62%. Comparing base (9a2cc9f) to head (bb478ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1069 +/- ## ======================================= Coverage 93.62% 93.62% ======================================= Files 112 112 Lines 3374 3374 Branches 957 956 -1 ======================================= Hits 3159 3159 Misses 199 199 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.