search

morelinq / MoreLINQ

Extensions to LINQ to Objects
https://morelinq.github.io/
Apache License 2.0
3.68k stars 412 forks source link

Buffering #87

Open atifaziz opened 9 years ago

atifaziz commented 9 years ago

The use of buffering on Repeat() and Cartesian() is currently commented as a TODO. The attached patch:

  1. Implements a buffering class that buffers enumerables in memory.
  2. Changes Repeat() and Cartesian to use this buffering.
  3. Further changes Repeat() to skip this if the count is 0 or 1.
  4. Defines an IBufferedEnumerable<T> interfaces, documented as adding a buffering guarantee to IEnumerable<T>.
  5. Defines two overloads of a method to create such a buffered instance. One of which insists that buffering happen even if the source implements ICollection<T>. (Otherwise it is assumed that the source already serves as a buffer adequately).

In short: Deals with the two TODO items, and brings the advantage of the code needed to do so, to the user.

Originally reported on Google Code with ID 87

Reported by jonhanna76.JH on 2013-12-12 14:46:28

atifaziz commented 9 years ago

Sorry, there was a slight error in the XML documentation. Further patch:

Reported by jonhanna76.JH on 2013-12-12 14:52:43

fsateler commented 8 years ago

This is the same as #100