morelinq / MoreLINQ

Extensions to LINQ to Objects
https://morelinq.github.io/
Apache License 2.0
3.67k stars 412 forks source link

Add generic version of `Sequence` for any number type #893

Closed atifaziz closed 1 week ago

atifaziz commented 1 year ago

This PR adds a generic version of Sequence as described in #892.

Under .NET 7, Sequence(int, int, int) defers to Sequence<T>(T, T, T) and is therefore tested for when T is int.

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.22%. Comparing base (5dc9e18) to head (1ac5b79). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
MoreLinq/Sequence.cs 94.44% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #893 +/- ## ========================================== - Coverage 93.23% 93.22% -0.01% ========================================== Files 112 112 Lines 3400 3410 +10 Branches 962 962 ========================================== + Hits 3170 3179 +9 - Misses 214 215 +1 Partials 16 16 ``` | [Flag](https://app.codecov.io/gh/morelinq/MoreLINQ/pull/893/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morelinq) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/morelinq/MoreLINQ/pull/893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morelinq) | `93.22% <94.44%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morelinq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

viceroypenguin commented 1 year ago

Approved in principle. Will wait to give final approval.