search

morelinq / MoreLINQ

Extensions to LINQ to Objects
https://morelinq.github.io/
Apache License 2.0
3.7k stars 415 forks source link

Retire our delegating `Comparer` #921

Closed atifaziz closed 1 year ago

atifaziz commented 1 year ago

This PR removes Comparer in favour of Delegate.Comparer from Delegating that provides the same functionality.

atifaziz commented 1 year ago

Is there a reason not to use System.Collections.Generic.Comparer<T>.Create()?

None. It's what happens when you work late. 😉 Thanks for the review! Fixed with c3dfb1996d46e7db773861d8da3d56075158c41c.

codecov[bot] commented 1 year ago

Codecov Report

Merging #921 (d625bcd) into master (34c7ebe) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #921   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files         112      112           
  Lines        3440     3440           
  Branches     1018     1018           
=======================================
  Hits         3180     3180           
  Misses        199      199           
  Partials       61       61

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more