search

morelinq / MoreLINQ

Extensions to LINQ to Objects
https://morelinq.github.io/
Apache License 2.0
3.67k stars 412 forks source link

Remove `Concat` that's been obsolete since 3.0 #993

Closed atifaziz closed 1 year ago

atifaziz commented 1 year ago

The Concat method was superseded by Append (see #496) and Concat has been marked obsolete since version 3.0. It's time to remove it with the next major version.

pflajszer commented 1 year ago

Hey atifaziz. I can see that Concat already calls Append internally. Is is just a matter of removing that single method in Append.cs? It's also in the README, so not sure if you'd like to keep it there too for now.

Happy to take that one if you're ok with that? I'm just getting comfortable contributing to OS projects, so that looks like a reasonable one to start with.

Thanks

atifaziz commented 1 year ago

Is is just a matter of removing that single method in Append.cs?

Yes.

It's also in the README, so not sure if you'd like to keep it there too for now.

It's already crossed out, but for starters, we can just change the following:

This method is obsolete and will be removed in a future version.

to

This method was removed with version 4.0.

Happy to take that one if you're ok with that?

Awesome.

I'm just getting comfortable contributing to OS projects, so that looks like a reasonable one to start with.

It's definitely a light one to get started with. Good luck and look forward to your PR.

pflajszer commented 1 year ago

Thanks a lot @atifaziz . Here's the PR: link. Please let me know if that looks OK!