moremoban / pypi-mobans

general python package templates using moban
Other
6 stars 7 forks source link

format script shall be a shell script not a part of Makefile #149

Closed chfw closed 4 years ago

chfw commented 4 years ago
format:
    isort -y $(find moban_handlebars -name "*.py"|xargs echo) $(find tests -name "*.py"|xargs echo)
    black -l 79 moban_handlebars
    black -l 79 tests

will format docs/source/conf.py anyway.

but we do not want that to happen as it is generated by moban, which is not compliant with black but is not our quality focus.

chfw commented 4 years ago

more details here: https://github.com/moremoban/moban-slim/commit/da605cb5863b05e8cc1faf118a297a15611013c3