search

moremoban / yehua

Make a project in 1 minute from a project template but keep updating it forever
http://yehua.readthedocs.io/
Other
22 stars 5 forks source link

Non-verbose mode as default #38

Closed jayvdb closed 4 years ago

jayvdb commented 4 years ago

The yehua output contains:

Requirement already satisfied: pypi-mobans-pkg==0.0.7 in /home/python3.7/lib/python3.7/site-packages (0.0.7)
Requirement already satisfied: lml in /home/python3.7/lib/python3.7/site-packages (from pypi-mobans-pkg==0.0.7) (0.0.9)

IMO that is unnecessary except in a verbose mode, which shouldnt be default.

Also I dont see how it is beneficial for a moban template pkg to include lml , as moban already depends on it, so it should already exist..?

chfw commented 4 years ago

With hindsight, it should not depend on lml

jayvdb commented 4 years ago

Also I see Warning: 'requires' is deprecated since 0.6.0! Please use pypi:// or git:// notation instead , but I think I am using the latest yehua and moban and pypi-moban-pkg. Something somewhere must be using old syntax...?

chfw commented 4 years ago

Yes, moban file needs updating

chfw commented 4 years ago

the following legacy code exists in the library. That's why lml was listed. With pypifs, lml related code shall exist the stage. 

# flake8: noqa
import os
from pypi_mobans_pkg._version import __version__
from pypi_mobans_pkg._version import __author__
from lml.plugin import PluginInfo

@PluginInfo('library', tags=['setupmobans', 'pypi', 'pypi-mobans-pkg'])
class Pypkg():
    def __init__(self):
        __package_path__ = os.path.dirname(__file__)
        self.resources_path = os.path.join(
            __package_path__, "resources")

the only plus point is: pypi-mobans-pkg will support older version of moban < 0.6.0.

chfw commented 4 years ago

above code has been removed in pypi-moban-pkg 0.0.13, so such legacy use is gone forever.

https://travis-ci.org/github/moremoban/moban/jobs/682686615