morenoh149 / react-native-contacts

React Native Contacts
MIT License
1.64k stars 560 forks source link

Not RN 0.64 compatible #600

Closed milesj closed 3 years ago

milesj commented 3 years ago

@morenoh149

App will not compile for RN 0.64 since the minimum version was bumped to 23. Seems like an easy fix.

> Task :react-native-contacts:processDebugAndroidTestManifest FAILED
--
  | [androidx.vectordrawable:vectordrawable-animated:1.0.0] /root/.gradle/caches/transforms-2/files-2.1/34f87ae3aab65bfd5a1ac17452ff5394/vectordrawable-animated-1.0.0/AndroidManifest.xml Warning:
  | Package name 'androidx.vectordrawable' used in: androidx.vectordrawable:vectordrawable-animated:1.0.0, androidx.vectordrawable:vectordrawable:1.0.1.
  | /workdir/node_modules/react-native-contacts/android/build/intermediates/tmp/manifest/androidTest/debug/manifestMerger6808068113717720989.xml:5:5-74 Error:
  | uses-sdk:minSdkVersion 16 cannot be smaller than version 21 declared in library [com.facebook.react:react-native:0.64.0] /root/.gradle/caches/transforms-2/files-2.1/bf54b844f524ab8e44f44b68a7baaeb8/jetified-react-native-0.64.0/AndroidManifest.xml as the library might be using APIs not available in 16
  | Suggestion: use a compatible library with a minSdk of at most 16,
  | or increase this project's minSdk version to at least 21,
  | or use tools:overrideLibrary="com.facebook.react" to force usage (may lead to runtime failures)
morenoh149 commented 3 years ago

@milesj submit a PR